Open
Conversation
This did not actually break any samples because even the PTS + Pos combination was enough to uniquely identify all packets in the test files, but before this commit the Hidden comparison was broken on packets that had a Hidden flag set. After this commit, all FindPacket calls in all test cases find the packet using the first check (comparing all fields) or not at all.
Apart from being a tiny optimization this makes it easier to check for which sample files there are packets are not being found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This did not actually break any samples because even the PTS + Pos
combination was enough to uniquely identify all packets in the test
files, but before this commit the Hidden comparison was broken on
packets that had a Hidden flag set.
Either way, sorry for introducing this bug.